Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix linking to libsodium on macOS #7908

Merged

Conversation

fanquake
Copy link
Contributor

@fanquake fanquake commented Dec 5, 2024

Currently (using master) on I see link failures like the following:

./configure
<snip>
checking for libsodium with IETF chacha20 variants... yes
<snip>
ar libccan.a
ld ccan/ccan/cdump/tools/cdump-enumstr
ld: library 'sodium' not found
clang: error: linker command failed with exit code 1 (use -v to see invocation)

The configure check passes under Clang here. Switch to using pkg-conf(ig) to track down the libs.

Changelog-Fixed: build: fix linking against libsodium on macOS.

Currently on I see link failures like the following:
```bash
./configure
<snip>
checking for libsodium with IETF chacha20 variants... yes
<snip>
ar libccan.a
ld ccan/ccan/cdump/tools/cdump-enumstr
ld: library 'sodium' not found
clang: error: linker command failed with exit code 1 (use -v to see invocation)
```

The configure check passes under Clang here.

Changelog-Fixed: build: fix linking against libsodium on macOS.
@rustyrussell rustyrussell added this to the v25.02 milestone Jan 22, 2025
@rustyrussell rustyrussell merged commit 305c377 into ElementsProject:master Jan 22, 2025
36 of 39 checks passed
@fanquake fanquake deleted the lib_sodium_not_found_macos branch January 23, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants